Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mergeMap): readd resultSelector as deprecated #3494

Merged
merged 7 commits into from
Mar 30, 2018

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Mar 30, 2018

Readds the resultSelector, as deprecated, to

  • mergeMap
  • mergeMapTo
  • switchMap
  • switchMapTo
  • concatMap
  • concatMapTo
  • exhaustMap

... relies on map tests for error handling

@benlesh benlesh requested a review from jasonaden March 30, 2018 00:41
@rxjs-bot
Copy link

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@benlesh benlesh removed the request for review from jasonaden March 30, 2018 18:01
@benlesh benlesh merged commit 20861f8 into ReactiveX:master Mar 30, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants